fix(bb-sol): collapse Debug.sol import to forge-fmt-stable form#23146
Closed
AztecBot wants to merge 1 commit into
Closed
fix(bb-sol): collapse Debug.sol import to forge-fmt-stable form#23146AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added
ci-draft
Contributor
|
close in favour of #23168 |
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
May 16, 2026
…Protocol#23168) ## Summary Companion to AztecProtocol#23146 (merge-train/barretenberg), recreated against `next`. `barretenberg/sol/bootstrap.sh::build_sol` runs `forge fmt` before `forge build`. PR AztecProtocol#22659 (now in `next` via merge-train/fairies) trimmed unused imports from `test/utils/Debug.sol`; once trimmed, the multi-line import block was short enough that `forge fmt` collapses it to a single line. That rewrites the file mid-CI and trips `ci3/cache_content_hash` with `ERROR: Noticed changes to rebuild patterns during CI run`, disabling cache hits for every downstream `*-tests` target — as seen in http://ci.aztec-labs.com/1778494208886637. This PR puts `Debug.sol` directly into the forge-fmt-stable form (single-line import). After rebase, this is the only diff against `next`. ## Verification ```bash cd barretenberg/sol forge fmt --check # clean forge fmt # no changes ``` Full analysis: https://gist.github.com/AztecBot/86bb7e59c1a9998f77dd1bc51dd9319d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
barretenberg/sol/bootstrap.sh::build_solrunsforge fmtbeforeforge build. After PR #22659 trimmed unused imports fromtest/utils/Debug.sol, the multi-line import block became short enough thatforge fmtcollapses it to a single line — but the file was committed in its multi-line shape. That rewrites the file mid-CI and triggersci3/cache_content_hash's "Noticed changes to rebuild patterns" warning, disabling cache hits for every downstream*-teststarget.Failing CI: http://ci.aztec-labs.com/1778494208886637 —
[bb-sol-tests] ERROR: Noticed changes to rebuild patterns during CI run: barretenberg/sol/test/utils/Debug.sol(and the same onyarn-project-tests,boxes-tests,playground-tests,aztec-up-tests).This commits the file in the form
forge fmtalready produces, so the working tree stays clean during CI.Verification
Full analysis: https://gist.github.com/AztecBot/671170ebb26d05023e0563fe83850046
ClaudeBox log: https://claudebox.work/s/656b4ce2b1e5e7de?run=1